Error message when key/nonkey configuration doesn't match actual behaviour #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll hopefully have a followup Pull Request that enhances the aggregator so it respects the configuration (by having the default aggregation behaviour for non-keys be 'first flow', as is commonly done on pretty much all other netflow probes) |
ogasser
requested changes
Sep 10, 2018
…viour
Using a 'traditional' flow definition like that below will result in:
vermont[4729]: Field bgpDestinationAsNumber configured as nonFlowKey will not be Aggregated
vermont[4729]: Field bgpSourceAsNumber configured as nonFlowKey will not be Aggregated
vermont[4729]: Field destinationIPv4PrefixLength configured as nonFlowKey will not be Aggregated
vermont[4729]: Field egressInterface configured as nonFlowKey will not be Aggregated
vermont[4729]: Field ipNextHopIPv4Address configured as nonFlowKey will not be Aggregated
vermont[4729]: Field sourceIPv4PrefixLength configured as nonFlowKey will not be Aggregated
<rule>
<flowKey>
<ieName>destinationIPv4Address</ieName>
<autoAddV4PrefixLength>false</autoAddV4PrefixLength>
</flowKey>
<flowKey>
<ieName>destinationTransportPort</ieName>
</flowKey>
<flowKey>
<ieName>ingressInterface</ieName>
</flowKey>
<flowKey>
<ieName>ipClassOfService</ieName>
</flowKey>
<flowKey>
<ieName>protocolIdentifier</ieName>
</flowKey>
<flowKey>
<ieName>sourceIPv4Address</ieName>
<autoAddV4PrefixLength>false</autoAddV4PrefixLength>
</flowKey>
<flowKey>
<ieName>sourceTransportPort</ieName>
</flowKey>
<nonFlowKey>
<ieName>bgpDestinationAsNumber</ieName>
</nonFlowKey>
<nonFlowKey>
<ieName>bgpSourceAsNumber</ieName>
</nonFlowKey>
<nonFlowKey>
<ieName>destinationIPv4PrefixLength</ieName>
</nonFlowKey>
<nonFlowKey>
<ieName>egressInterface</ieName>
</nonFlowKey>
<nonFlowKey>
<ieName>flowEndMilliseconds</ieName>
</nonFlowKey>
<nonFlowKey>
<ieName>flowStartMilliseconds</ieName>
</nonFlowKey>
<nonFlowKey>
<ieName>ipNextHopIPv4Address</ieName>
</nonFlowKey>
<nonFlowKey>
<ieName>octetDeltaCount</ieName>
</nonFlowKey>
<nonFlowKey>
<ieName>packetDeltaCount</ieName>
</nonFlowKey>
<nonFlowKey>
<ieName>sourceIPv4PrefixLength</ieName>
</nonFlowKey>
<nonFlowKey>
<ieName>tcpControlBits</ieName>
</nonFlowKey>
</rule>
nickbroon
force-pushed
the
ignored_key_nonkey_config
branch
from
34f85e2 to
9f2b3eb
Compare
|
Thanks for the PR and the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an error message when key/nonkey configuration doesn't match actual behaviour (as reported in #112).
Using a 'traditional' flow definition like that below will result in:
vermont[4729]: Field bgpDestinationAsNumber configured as nonFlowKey will not be Aggregated
destinationIPv4Address false destinationTransportPort ingressInterface ipClassOfService protocolIdentifier sourceIPv4Address false sourceTransportPort bgpDestinationAsNumber bgpSourceAsNumber destinationIPv4PrefixLength egressInterface flowEndMilliseconds flowStartMilliseconds ipNextHopIPv4Address octetDeltaCount packetDeltaCount sourceIPv4PrefixLength tcpControlBitsvermont[4729]: Field bgpSourceAsNumber configured as nonFlowKey will not be Aggregated
vermont[4729]: Field destinationIPv4PrefixLength configured as nonFlowKey will not be Aggregated
vermont[4729]: Field egressInterface configured as nonFlowKey will not be Aggregated
vermont[4729]: Field ipNextHopIPv4Address configured as nonFlowKey will not be Aggregated
vermont[4729]: Field sourceIPv4PrefixLength configured as nonFlowKey will not be Aggregated