Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add custom 404 page #486

Merged
merged 5 commits into from
Feb 3, 2025
Merged

docs: add custom 404 page #486

merged 5 commits into from
Feb 3, 2025

Conversation

marcalexiei
Copy link
Member

@marcalexiei marcalexiei commented Feb 3, 2025

Checklist

Related issue

Pending

Fixes #487

Overview

  • Customise 404 page.
  • Edit page link is no longer present in the home page:
    I created a new layout inside documentation routes where it is displayed.
    I don't think is a problem, I prefer to not have this link in the home and in a simple page like 404
    but let me know I have to restore it.
  • MdxWrapper has been renamed to PageWithTOC to be more semantic.
  • TableOfContents refinements:
    • anchor click has been refined to use event.target href to retrieve the relative header.
    • components no longer render everything if the page doesn't contain data-order headers
      (like the 404 page).

@marcalexiei marcalexiei self-assigned this Feb 3, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 3, 2025
@marcalexiei marcalexiei changed the title Docs 404 docs: add custom 404 page Feb 3, 2025
@marcalexiei marcalexiei linked an issue Feb 3, 2025 that may be closed by this pull request
@marcalexiei marcalexiei marked this pull request as ready for review February 3, 2025 08:48
Valerioageno
Valerioageno previously approved these changes Feb 3, 2025
@marcalexiei marcalexiei merged commit 97b9d71 into main Feb 3, 2025
18 checks passed
@marcalexiei marcalexiei deleted the docs-404 branch February 3, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation]: add custom 404 page
2 participants