-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add css key to vite config #518
Conversation
@jacobhq does this PR fix the bug you linked on your local setup? |
To use the solution:
We need to upgrade This PR is still valid and useful, but it won't fix #504 unless we upgrade |
Why do we need to update vite here? The goal is to deliver quality on the first iteration (when the fix is small/medium size) for multiple reasons:
Please make this PR draft and ask for review when the whole bug fix is addressed. If you need help we can sync on Discord |
Current version of
Sorry, I didn't realise we had this config build step. I will update it, which will add CSS config support, however even after this, the issue won't be fixed unless we upgrade Again, sorry about the early review. |
I see two task to fix this issue:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f2737be
to
9919c5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next time, could you please follow the contributing guidelines and procedures?
https://tuono.dev/documentation/contributing/pull-requests#overview
Please don't:
Do not use force push after marking the PR ready for review.
Reasoning: GitHub cannot track changes across force pushes, which slows down our ability to perform incremental reviews.
https://tuono.dev/documentation/contributing/pull-requests#addressing-review-feedback
After addressing all feedback, whether through code changes or by starting a follow-up discussion, please re-request a review from each maintainer whose feedback you've addressed.
Thanks
I left one comment regarding the documentation text for the option.
Yep, thanks. In future I will merge instead of rebase, so no more force pushes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me.
Checklist
Related issue
Fixes #504
Overview
Add CSS key to vite config.