Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update vite to v6 and vitest v3 #576

Merged
merged 2 commits into from
Feb 22, 2025
Merged

feat: update vite to v6 and vitest v3 #576

merged 2 commits into from
Feb 22, 2025

Conversation

marcalexiei
Copy link
Member

@marcalexiei marcalexiei commented Feb 17, 2025 •
edited
Loading

Checklist

Related issue

Fixes #567

Overview

Update vite to v6 and vitest v3

@marcalexiei marcalexiei self-assigned this Feb 17, 2025
@github-actions github-actions bot added typescript Requires typescript knowledge repo maintenance linting, fs organization, that sort of stuff labels Feb 17, 2025
@marcalexiei marcalexiei marked this pull request as ready for review February 22, 2025 13:43
Valerioageno
Valerioageno approved these changes Feb 22, 2025
View reviewed changes
Copy link
Member

@Valerioageno Valerioageno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@marcalexiei
Copy link
Member Author

@jacobhq Is it okay if I merge this into main?
Then you can merge the changes from main and we can test #584 with Vite 6.

jacobhq
jacobhq approved these changes Feb 22, 2025
View reviewed changes
Copy link
Member

@jacobhq jacobhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that sounds like a good plan! Thanks for checking :)

@Valerioageno Valerioageno merged commit 0a4d1e2 into main Feb 22, 2025
20 checks passed
@Valerioageno Valerioageno deleted the vite-6 branch February 22, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobhq jacobhq jacobhq approved these changes

@Valerioageno Valerioageno Valerioageno approved these changes

Assignees

@marcalexiei marcalexiei

Labels
repo maintenance linting, fs organization, that sort of stuff typescript Requires typescript knowledge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to vite 6
3 participants
@marcalexiei @jacobhq @Valerioageno