feat(packages/tuono-router): add replace method to router and replace prop to Link
#596
+59
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcalexiei
reviewed
Feb 24, 2025
Valerioageno
previously approved these changes
Feb 24, 2025
|
@m-jovan, sorry to bother you, could you please re-request a review after you have completed the changes (more info)? |
marcalexiei
approved these changes
Feb 24, 2025
marcalexiei
changed the title
replace method to router and replace prop to Link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Related issue
Fixes #537
Overview
This PR does the following:
replacemethod to the instance returned byuseRouterhookuseRoutertypes to avoid repetition with addingreplacemethodreplaceprop toLinkcomponent that replaces the state by calling router's now addedreplacemethodRelated docs will be added with tuono-labs/tuono-documentation#30