Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add further hiding / closing of apps when screen sharing #20

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Add further hiding / closing of apps when screen sharing #20

merged 3 commits into from
Nov 3, 2023

Conversation

stevysmith
Copy link
Contributor

@stevysmith stevysmith commented Nov 3, 2023 •
edited
Loading

  • Close Gmail Tabs - closes gmail tabs from open Chrome windows
  • Hide Discord - hides discord mac app
  • Hide Slack - hides slack mac app
  • Hide Notes - hides notes mac app

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023 •
edited
Loading

Thanks for your contribution, @stevysmith! 🎉

We've done some automated sense checks on your triggers. All looks great! Someone from Tuple will now manually review your triggers' code and get back to you.

close-gmail-tabs

  • All good! ✅

hide-discord

  • All good! ✅

hide-notes

  • All good! ✅

hide-slack

  • All good! ✅

@stevysmith stevysmith changed the title Add further hiding / closing of apps when screen sharing Slack Share Update and add further hiding / closing of apps when screen sharing Nov 3, 2023
@mcmillan
Copy link
Member

mcmillan commented Nov 3, 2023

Hi @stevysmith! Would you mind splitting this up into two PRs – keeping this one for close-gmail-tabs / hide-discord / hide-notes and hide-slack, and creating a new one for slack-share-update? The first four are pretty straightforward, but the last one might need a bit more reviewing 😄

@stevysmith
Copy link
Contributor Author

Sure thing

@stevysmith stevysmith changed the title Slack Share Update and add further hiding / closing of apps when screen sharing Add further hiding / closing of apps when screen sharing Nov 3, 2023
mcmillan
mcmillan approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@mcmillan mcmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @stevysmith!

@mcmillan mcmillan merged commit 7dc82fd into tupleapp:main Nov 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmillan mcmillan mcmillan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevysmith @mcmillan