Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct a few arguments and event names #23

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

mcasper
Copy link
Contributor

@mcasper mcasper commented Nov 8, 2023

  • screen-share-stop should be screen-share-ended
  • TUPLE_TRIGGER_IS_SELF will either be the string "true" or the string "false", not empty/populated.

* `screen-share-stop` should be `screen-share-ended`
* `TUPLE_TRIGGER_IS_SELF` will either be the string "true" or the string
  "false", not empty/populated.
@mcasper mcasper requested a review from mcmillan November 8, 2023 16:29
Copy link

github-actions bot commented Nov 8, 2023

Thanks for your contribution, @mcasper! 🎉

We've done some automated sense checks on your triggers. All looks great! Someone from Tuple will now manually review your triggers' code and get back to you.

close-gmail-tabs

  • All good! ✅

hide-1password

  • All good! ✅

hide-desktop-icons

  • All good! ✅

hide-discord

  • All good! ✅

hide-messages

  • All good! ✅

hide-notes

  • All good! ✅

hide-slack

  • All good! ✅

iterm-command

  • All good! ✅

slack-room-notify

  • All good! ✅

@SpencerCDixon SpencerCDixon merged commit f2e3e81 into main Nov 10, 2023
1 check passed
@SpencerCDixon SpencerCDixon deleted the matt/event-name-and-argument-corrections branch November 10, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants