github actions: use offical UPX, update .editorconfig #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update .editorconfig so my Emacs doesn't add tabs into the YAML files anymore * The UPX version in ubuntu doesn't use the NRV library and seems to be a bit buggier. Furthermore, UPX is GPL and they allow an exception only if the binary is compressed with the official build. The latter is not really a problem, nobody will care, but the worse compression and potential crashes are. So just use the official build for Linux. Windows was already using it, but to keep it consistent with UPX_VERSION we now also download it instead of using Chocolatey.
brakhane
force-pushed
the
official-upx
branch
from
7fa7841 to
e8265c5
Compare
turanszkij
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update .editorconfig so my Emacs doesn't add tabs into the YAML files anymore
The UPX version in ubuntu doesn't use the NRV library and seems to be a bit buggier. Furthermore, UPX is GPL and they allow an exception only if the binary is compressed with the official build. The latter is not really a problem, nobody will care, but the worse compression and potential crashes are. So just use the official build for Linux. Windows was already using it, but to keep it consistent with UPX_VERSION we now also download it instead of using Chocolatey.