Skip to content

Commit

Permalink
Readd GetScanMetadata to scanIteratorBase so that scanIteratorLocal i…
Browse files Browse the repository at this point in the history
…mplements PluginIterator
  • Loading branch information
kaidaguerre committed Apr 23, 2024
1 parent c4fd1b2 commit 1808393
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
5 changes: 5 additions & 0 deletions hub/hub_base.go
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,13 @@ func (h *hubBase) StartScan(i Iterator) error {
log.Printf("[INFO] hubBase StartScan")

// if iterator is not a pluginIterator, do nothing
// (i.e. is it an InMemoryIterator
// This code should never be called for them anyway as they are initialized to be in a `started` state,
// and the scan is started using the function executeCommandScan)
iterator, ok := i.(pluginIterator)
if !ok {
// unexpected
log.Printf("[WARN] StartScan called for non-pluginIterator %T", i)
return nil
}

Expand Down
4 changes: 4 additions & 0 deletions hub/scan_iterator_base.go
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,10 @@ func (i *scanIteratorBase) GetQueryTimestamp() int64 {
return i.queryTimestamp
}

func (i *scanIteratorBase) GetScanMetadata() []queryresult.ScanMetadataRow {
return nil
}

func (i *scanIteratorBase) newExecuteRequest() *proto.ExecuteRequest {
req := &proto.ExecuteRequest{
Table: i.table,
Expand Down

0 comments on commit 1808393

Please sign in to comment.