-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cate Profir IC4 #4
Open
cateprofir13
wants to merge
19
commits into
turingschool-examples:main
Choose a base branch
from
cateprofir13:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bit and if that object can take in attributes. i checked the expected behaviour of the initialize method by passing in the Gems and minerals example
… name and cost from the hash.
… the name and spendig money attributes.
…pected behaviour by passing in two interest examples.
…ments in the interests array.
… name and exhibits attributes. I passed in examples to check the behaviour of the method.
…d added exhibits as an empty array for now. Added attr reader in oder for the method to be visible outiside the file
…t through the add_exhibits methods. I passed in three examples of exhibits to check the behaviour of the method.
…ects to the exhibits empty array with the examples pased in my test. During the execution of my code i realized my test were expecting objects instead of an array of objects so i went back an changed that, in order for the method to behave properly
…is class in order to access their information. Their interests name match the name of the exhibits and i used those to identify the expected output of the ethod.
…ling mistakes in my test. Came back to change those. Also my method was not recognizing the exhibits because i didnt add them to this test. I added that and the tests are now passing.
…ron in order to get the patron interest information. i used the find all method to iterate over the exhibits and find the mathcing values for interests.
… return a hash whwere the key are the main exhibits and keys are the patrons that are interersted in those.
… hash that would eventually be filled after the each loop. I iterarted over exhibits in order to get the patrons whose interest match the exhibit name. i used the exhibits key in order to add the patron value to the hash.
…nformation we already had from the previous tests. We need to check if the method can retuns the array of the patron contestanats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.