8307 remove support for legacy mailfolders non static mail listids #8474
+1,044
−872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Element and list element instances with customIds must be stored with their elementIds encoded as base64Ext in the offline database, to ensure that these elementIds are sortable when running SQL queries. When received from our server customId are encoded with base64Url, which is not sortable! When introducing MailSetEntries, which are using custom elementIds (customId type), we did refactor the OfflineStorage in such a way that all publicly exposed methods guarantee the correct encoding before reading / writing from / to the database. With a later commit f99bd69 some methods in the OfflineStorage got refactored which led to wrong encodings in certain scenarios. This commit ensures that custom elementIds are encoded correctly and are sortable in the OfflineStorage again.
Co-authored-by: abp <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.