Fix the type of array.elem and the mantis benchmark
#1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannham
requested review from
vkleen,
ebresafegaga and
dpl0a
and removed request for
dpl0a
vkleen
approved these changes
Apr 4, 2023
|
Addressed in f07ee8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to run the benchmarks on #1220, they were broken.
Beside updating to the latest stdlib changes, I had to fix the type of
array.elemwhich lies, because it's polymorphic but equality isn't actually parametric. This means that sadly, currently some statically typed code can actually fail its contract, because the equality is typed with_a -> _a -> Bool. Maybe it shouldn't. In the meantime, let fixelem, which currently fails on any reasonable usage with a spurious blame error.