Parse and output entire license list if present #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeDesforges
requested changes
Dec 20, 2023
ErinvanderVeen
force-pushed
the
license-list
branch
2 times, most recently
from
0d36acd to
4c19ec0
Compare
GuillaumeDesforges
requested changes
Jan 2, 2024
ErinvanderVeen
force-pushed
the
license-list
branch
from
4c19ec0 to
36ba8ff
Compare
ErinvanderVeen
force-pushed
the
license-list
branch
from
36ba8ff to
4b76cf0
Compare
GuillaumeDesforges
requested changes
Jan 4, 2024
|
The fact that the tests passed even though the Nix expression had a problem makes me think we need an additional automated test. Could you write one? |
ErinvanderVeen
force-pushed
the
license-list
branch
from
8b40ef1 to
9c968fe
Compare
ErinvanderVeen
force-pushed
the
license-list
branch
from
9c968fe to
de38a42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the full license name to the
spdxIdinstead, which I argue is better suited for the purpose anyway.