-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rust toolchain to use rules_rust 0.22.0 #393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Small comment about the version bump.
Thanks for the PR @contagnas! It looks like CI is failing with this error:
Which is odd, if |
@@ -1,6 +1,6 @@ | |||
{ | |||
"homepage": "https://bazelbuild.github.io/rules_rust/", | |||
"maintainers": [], | |||
"versions": ["0.17.0"], | |||
"versions": ["0.22.0"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with bzlmod yet, so it's not clear to me if this registry should have multiple version of dependencies, or just the current one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This registry is only used for testing (see readme), so a single version is enough.
@@ -1,5 +1,5 @@ | |||
{ | |||
"url": "https://github.com/bazelbuild/rules_rust/releases/download/0.17.0/rules_rust-v0.17.0.tar.gz", | |||
"url": "https://github.com/bazelbuild/rules_rust/releases/download/0.22.0/rules_rust-v0.22.0.tar.gz", | |||
"integrity": "sha384-v3eVoRi4rdkELxzV3egjTJkc8M3UH1YmbdZ2m6Y45gpjBew4a/JU5A4TFNO8Bq3z", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expected this sha to need an update, but I can't find anything that uses it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bazel checks against this sha after downloading the dependency. I think it will also cache based on that sha, so if it's not updated you may get an old artifact.
A different CI error now 🤔
|
The expected hash that gets printed when there's a mismatch is in hexadecimal, but the hash in
|
Fixed the failure in
|
rules_rust 0.22.0 removes rust_toolchain.os in bazelbuild/rules_rust#1960
note this change isn't compatible with earlier versions of rules_rust, because the os field was required.