Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward http_archive type to submodules #411

Merged
merged 2 commits into from
Sep 6, 2023
Merged

forward http_archive type to submodules #411

merged 2 commits into from
Sep 6, 2023

Conversation

malt3
Copy link
Collaborator

@malt3 malt3 commented Sep 4, 2023

This may be very specific to our deployment, but in my teams monorepo, we require any http_archive dependencies to be mirrored with a standardized file name.

As an example, we would depend on rules_nixpkgs like this:

http_archive(
    name = "io_tweag_rules_nixpkgs",
    sha256 = "3ff4a25c8021ce2b0a15b4892acd2246fb1aae1d143ecdbd12bb770ad6e1741d",
    strip_prefix = "rules_nixpkgs-52d34c00171acd04d27626571d7d40748d648d2a",
    urls = [
        "https://cdn.confidential.cloud/constellation/cas/sha256/3ff4a25c8021ce2b0a15b4892acd2246fb1aae1d143ecdbd12bb770ad6e1741d",
        "https://github.com/tweag/rules_nixpkgs/archive/52d34c00171acd04d27626571d7d40748d648d2a.tar.gz",
    ],
    type = "tar.gz",
)

This requires us to specify the type field in http_archive and to also forward this field in other http_archive rules that are created from the original rule.

@malt3 malt3 requested a review from benradf as a code owner September 4, 2023 17:06
@benradf benradf merged commit 97b8937 into tweag:master Sep 6, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants