forward http_archive type to submodules #411
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be very specific to our deployment, but in my teams monorepo, we require any
http_archive
dependencies to be mirrored with a standardized file name.As an example, we would depend on rules_nixpkgs like this:
This requires us to specify the
type
field inhttp_archive
and to also forward this field in otherhttp_archive
rules that are created from the original rule.