Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax highlighting for all languages except Nickel. #589

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Syntax highlighting for all languages except Nickel. #589

merged 3 commits into from
Oct 4, 2023

Conversation

torhovland
Copy link
Member

Fixes #543.

@torhovland torhovland marked this pull request as draft July 28, 2023 10:24
@torhovland torhovland marked this pull request as ready for review July 28, 2023 11:46
Xophmeister
Xophmeister approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@Xophmeister Xophmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks understandable, so I tentatively approve, to get this merged.

The output editor pane can contain a Topiary error message, which doesn't make sense to be highlighted. Would it be easy to switch to plain_text in such an event?

@ErinvanderVeen ErinvanderVeen merged commit 50318d0 into main Oct 4, 2023
4 checks passed
@ErinvanderVeen ErinvanderVeen deleted the 543-syntax-highlight-code branch October 4, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xophmeister Xophmeister Xophmeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syntax highlighting in the playground
3 participants
@torhovland @Xophmeister @ErinvanderVeen