signup sync with microsoft #10008
Open
signup sync with microsoft #10008
+57
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Both enabled : 
None enabled : One enabled : |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements Microsoft email and calendar sync functionality during the onboarding process, with environment variable controls for feature availability.
- Added Microsoft sync button in
/packages/twenty-front/src/pages/onboarding/SyncEmails.tsxwith conditional rendering based on environment variables - Introduced visibility settings in
/packages/twenty-front/src/modules/onboarding/components/onboardingSyncEmailsOptions.tsxfor controlling data sharing levels - Implemented
useSignInWithMicrosofthook in/packages/twenty-front/src/modules/auth/sign-in-up/hooks/useSignInWithMicrosoft.tsfor handling Microsoft authentication - Added skip functionality through
skipSyncEmailOnboardingStepmutation for users who don't want to sync
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
118
to
125
| {(isGoogleMessagingEnabled || isGoogleCalendarEnabled) && ( | ||
| <MainButton | ||
| title="Sync with Google" | ||
| onClick={() => handleButtonClick('google')} | ||
| width={200} | ||
| Icon={() => <IconGoogle size={theme.icon.size.sm} />} | ||
| /> | ||
| )} |
There was a problem hiding this comment.
style: Consider combining the Google and Microsoft button logic into a reusable component to reduce code duplication
guillim
added
-PR: awaiting review
scope: front
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want users to be able to sync their emails with microsoft duting signup
We also want to respect the env ariables that decide if we allow messaging and calendar providers.
design
https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=53729-251492&t=1cwVzB0xFAom9PlM-0