Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Added light background #7980

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

abdullah5361k
Copy link
Contributor

fixes: #7969

What does this PR do?

Applied a lighter background color on hover.

twenty-hover

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses the visibility issue of button hover effects in dark mode by applying a lighter background color on hover for dropdown buttons.

  • Modified StyledHeaderDropdownButton.tsx to add a light background color on hover using theme.background.transparent.light
  • Adjusted EmptyPlaceholderStyled.tsx with minor spacing and layout changes, reducing gap in StyledEmptyTextContainer and increasing line height in StyledEmptySubTitle
  • Improved visibility for filter, sort, and options buttons in dark mode as demonstrated in the provided screenshot
  • Changes align with the properly coded Storybook component mentioned in the related issue

2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines 24 to 27
&:hover {
filter: brightness(0.95);
background: ${({ theme }) => theme.background.transparent.light};
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider removing the brightness filter as it may interfere with the new background color

@Bonapara
Copy link
Member

Doesn't work for me:

CleanShot.2024-10-23.at.09.35.27.mp4

Why did you change the Emptyplaceholder file @abdullah5361k?

Also I think we are supposed to use this component here: packages/twenty-front/src/modules/ui/input/button/components/LightButton.tsx

WDYT @lucasbordeau?

@abdullah5361k
Copy link
Contributor Author

abdullah5361k commented Oct 24, 2024

Doesn't work for me:

CleanShot.2024-10-23.at.09.35.27.mp4
Why did you change the Emptyplaceholder file @abdullah5361k?

Also I think we are supposed to use this component here: packages/twenty-front/src/modules/ui/input/button/components/LightButton.tsx

WDYT @lucasbordeau?

Let me check why it's not working for you.
My last pull request includes changes to the EmptyPlaceholder file. I'm not sure why this file is showing as changed this time, but I'm looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light icon button hover is not visible in Dark mode
3 participants