-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Added light background #7980
base: main
Are you sure you want to change the base?
Fix: Added light background #7980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request addresses the visibility issue of button hover effects in dark mode by applying a lighter background color on hover for dropdown buttons.
- Modified
StyledHeaderDropdownButton.tsx
to add a light background color on hover usingtheme.background.transparent.light
- Adjusted
EmptyPlaceholderStyled.tsx
with minor spacing and layout changes, reducing gap inStyledEmptyTextContainer
and increasing line height inStyledEmptySubTitle
- Improved visibility for filter, sort, and options buttons in dark mode as demonstrated in the provided screenshot
- Changes align with the properly coded Storybook component mentioned in the related issue
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
&:hover { | ||
filter: brightness(0.95); | ||
background: ${({ theme }) => theme.background.transparent.light}; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider removing the brightness filter as it may interfere with the new background color
Doesn't work for me: CleanShot.2024-10-23.at.09.35.27.mp4Why did you change the Emptyplaceholder file @abdullah5361k? Also I think we are supposed to use this component here: WDYT @lucasbordeau? |
Let me check why it's not working for you. |
fixes: #7969
What does this PR do?
Applied a lighter background color on hover.