Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added return type for build function #12

Closed
wants to merge 1 commit into from
Closed

fix: added return type for build function #12

wants to merge 1 commit into from

Conversation

LaurentSanson
Copy link

Hi there,

In order to get rid of some deprecation warnings, I'd like to submit this PR.

Warning in question :

User Deprecated: Method "Symfony\Component\HttpKernel\Bundle\Bundle::build()" might add "void" as a native return type declaration in the future. Do the same in child class "Twig\Extra\TwigExtraBundle\TwigExtraBundle" now to avoid errors or add an explicit @return annotation to suppress this message.

Cheers,

Laurent

@github-actions
Copy link

Thanks for your pull request! We love contributions.

However, you should instead open a pull request on the main repository:

https://github.com/twigphp/Twig

This repository is what we call a "subtree split": a read-only subset of that main repository.

We're looking forward to your PR there!

@github-actions github-actions bot closed this Oct 25, 2023
@LaurentSanson
Copy link
Author

How am I supposed to submit a PR from the main repo as I don't have the rights for it? @fabpot ?

Thanks and have a good one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant