feat: Validate AccountSid on Init #533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Throws exception if a API call tries to use AccountSid when it's not set.
| @@ -28,7 +28,7 @@ public class TwilioRestClient : ITwilioRestClient | |||
| /// <summary> | |||
| /// Account SID to use for requests | |||
| /// </summary> | |||
| public string AccountSid { get; } | |||
| public string AccountSid => _accountSid ?? throw new ArgumentException("AccountSID not set in " + nameof(TwilioClient) + "." + nameof(TwilioClient.Init)); | |||
There was a problem hiding this comment.
It's a bit odd having the getter throw an exception, but I can't think of a better solution that doesn't touch hundreds of files.
| AccountSid = accountSid ?? username; | ||
| _accountSid = accountSid; | ||
| //Validate prefix in accountSid, https://www.twilio.com/docs/glossary/what-is-a-sid#common-sid-prefixes | ||
| if (_accountSid?.StartsWith("AC", StringComparison.Ordinal) == false) |
There was a problem hiding this comment.
Logic looks sound to me, but some tests would ease my mind more.
There was a problem hiding this comment.
Thanks, I will see what I can do about adding tests.
|
Closing due to inactivity. Please ping here if work is to continue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #531
For API:s that require AccountSid this PR will make sure that AccountSid is set.
Before "username" was assumed to be AccountSid which caused 404 errors for API calls that expected AccountSid to be set.
Checklist