chore: removed .npmignore #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| !/.travis.yml | ||
|
|
||
| ### Spec and test coverage ### | ||
| spec |
There was a problem hiding this comment.
If we rely on .gitignore to be picked up while doing npm pack, the spec folder and .git files will also get packed. Can you run npm pack locally and see what's the difference in package size, shouldn't be impactful.
There was a problem hiding this comment.
Added spec folder and other files in .gitgnore as well
.gitignore
Outdated
| @@ -13,6 +16,12 @@ pids | |||
| ### NPM modules ### | |||
| node_modules | |||
|
|
|||
| ### Travis ### | |||
| !/.travis.yml | |||
There was a problem hiding this comment.
Can remove this since we dont have a travis.yml file. Rest LGTM.
shrutiburman
approved these changes
Jan 23, 2024
kridai
approved these changes
Jan 23, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Removed .npmignore since it is redundant with .gitignore
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.