Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: java enum type changes #187

Merged
merged 21 commits into from
Jul 13, 2022
Merged

fix: java enum type changes #187

merged 21 commits into from
Jul 13, 2022

Conversation

kridai
Copy link
Contributor

@kridai kridai commented Jul 13, 2022

Fixes

This PR covers the changes to support the enum ref changes added as part of the PR twilio/twilio-oai#71

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • Run make test-docker
  • Verify affected language:
    • Generate twilio-go from our OpenAPI specification using the build_twilio_go.py using python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go and inspect the diff
    • Run make test in twilio-go
    • Create a pull request in twilio-go
    • Provide a link below to the pull request
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

charan678 and others added 21 commits June 30, 2022 08:17
@kridai kridai requested a review from sbansla July 13, 2022 14:55
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

58.6% 58.6% Coverage
20.4% 20.4% Duplication

@charan678 charan678 merged commit ed92e3c into main Jul 13, 2022
@charan678 charan678 deleted the enum_type_schema branch July 13, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbansla sbansla sbansla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kridai @sbansla @charan678 @shrutiburman