Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add list path item with empty actions #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

charan678
Copy link
Contributor

Fixes

  • api definitions has files which contain list uri and instance uri properties, but in some of the cases there are no actions defined for list uri. But this list uri are referred by different api definitions as parent url, this scenario was missed while creating empty path Item object for parent urls in OAI spec and hence this created incorrect directory structure for some domains in twilio-java.
  • Adding endpoint and twiml format type to schema types

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Comment on lines +231 to +242
defaultOutputProperties:
- details
- email
- end_day
- estimated_completion_time
- friendly_name
- job_queue_position
- job_sid
- resource_type
- start_day
- webhook_method
- webhook_url
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: These aren't needed for empty paths.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants