Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add domain detail #739

Merged
merged 4 commits into from
Dec 13, 2023
Merged

chore: add domain detail #739

merged 4 commits into from
Dec 13, 2023

Conversation

manisha1997
Copy link
Contributor

@manisha1997 manisha1997 commented Dec 8, 2023

Fixes

chore: add Twilio domain details

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@manisha1997 manisha1997 changed the title Add domain detail chore: add domain detail Dec 8, 2023
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the preview_messaging/v1/ folder and its files can be omitted since they will be generated by OAI generator. But still, there is no loss having them beforehand.

twilio/rest/__init__.py Outdated Show resolved Hide resolved
twilio/rest/__init__.py Outdated Show resolved Hide resolved
twilio/rest/preview_messaging/PreviewMessagingBase.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiwarishubham635 tiwarishubham635 merged commit 568048c into 9.0.0-rc Dec 13, 2023
10 checks passed
@tiwarishubham635 tiwarishubham635 deleted the add_domain_detail branch December 13, 2023 12:43
tiwarishubham635 added a commit that referenced this pull request Feb 23, 2024
* feat: json content type (#737)

* feat: add application/json support for client

* feat: add application/json support for client

* feat: add application/json support for client

* feat: add application/json support for client

* feat: add application/json support for client

* chore: updated changelogs for rc-branch

* chore: add domain detail (#739)

* feat: add domain detail to twilio python

* feat: add domain detail to twilio python

* feat: add domain detail to twilio python

* feat: add domain detail to twilio python

* corrected rc version

* Update setup.py

* Update setup.py

* chore: corrected cluster test

* [Librarian] Regenerated @ 517c6276943255de674e1d20cdae01266b89160c dc7e93834d14ebcc1f96c25b9fbc8af35330f99a

* Release 9.0.0-rc.1

* chore: disables cluster test (#765)

* chore: disables cluster test

* chore: added make prettier to workflow

* [Librarian] Regenerated @ c3db20dd5f24647ef2bd3fb8b955496c59bb22bd d02e25fbcbae2224a4c0e6c23612622c320cce9f

* Release 9.0.0-rc.2

* feat!: MVR release preparation (#766)

* feat!: MVR release preparation

* fix: added test for json data in http client

---------

Co-authored-by: Manisha Singh <[email protected]>
Co-authored-by: sbansla <[email protected]>
Co-authored-by: Twilio <[email protected]>
sbansla added a commit that referenced this pull request Feb 23, 2024
* feat: add application/json support for client

* feat: add application/json support for client

* feat: add application/json support for client

* feat: add application/json support for client

* feat: add application/json support for client

* chore: updated changelogs for rc-branch

* chore: add domain detail (#739)

* feat: add domain detail to twilio python

* feat: add domain detail to twilio python

* feat: add domain detail to twilio python

* feat: add domain detail to twilio python

* corrected rc version

* Update setup.py

* Update setup.py

* chore: corrected cluster test

* chore: disables cluster test (#765)

* chore: disables cluster test

* chore: added make prettier to workflow

* feat!: MVR release preparation (#766)

* feat!: MVR release preparation

* fix: added test for json data in http client

---------

Co-authored-by: Manisha Singh <[email protected]>
Co-authored-by: sbansla <[email protected]>
Co-authored-by: Twilio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants