Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use older verison of aiohttp_retry #819

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

sbansla
Copy link
Contributor

@sbansla sbansla commented Oct 28, 2024

Fixes

https://github.com/inyutin/aiohttp_retry/
has released a latest version because of that we are getting error in our sdk build pipeline.

`

self = <aiohttp_retry.client._RequestContext object at 0x7f4176598d90>

  | current_attempt = 1
  | response = <tests.unit.http.test_async_http_client.MockResponse object at 0x7f4176516c50>
  |  
  | async def _is_skip_retry(self, current_attempt: int, response: ClientResponse) -> bool:
  | if current_attempt == self._retry_options.attempts:
  | return True
  |  
  | > if response.method not in self._retry_options.methods:
  | E AttributeError: 'MockResponse' object has no attribute 'method'

`

Fix:
Using older version and created an issue in aiohttp_retry repo.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Copy link

sonarcloud bot commented Oct 28, 2024

@sbansla sbansla merged commit 5aa42dc into main Oct 28, 2024
18 checks passed
@sbansla sbansla deleted the use-older-version-aiohttp_retry branch October 28, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants