fix: preserve track enabled state during cloning #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures track.enabled state is correctly maintained when cloning MediaStreamTracks. Addresses a Safari 18 bug where cloned tracks are incorrectly enabled during cloning. See https://commits.webkit.org/285916@main for more details.
Prevents "Cannot read properties of undefined" error when cloning data tracks by only setting the enabled state for audio/video tracks.
Sure thing! I just added both. |
charliesantos
requested changes
Nov 6, 2024
Comment on lines
+10
to
+22
| it(`should maintain track enabled state (${enabledState}) during publication`, () => { | ||
| const mediaStreamTrack = new FakeMediaStreamTrack('audio'); | ||
| mediaStreamTrack.enabled = enabledState; | ||
|
|
||
| const trackSender = new MediaTrackSender(mediaStreamTrack); | ||
| assert.strictEqual(trackSender.track.enabled, enabledState); | ||
|
|
||
| const publication = new LocalTrackPublicationSignaling(trackSender, 'track1', 'standard'); | ||
|
|
||
| assert.strictEqual(publication.trackTransceiver.track.enabled, enabledState); | ||
| assert.strictEqual(publication.isEnabled, enabledState); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
In order to properly test the Safari bug, we should also mock the behavior of the 'clone' function to always set the enabled state to 'true'. That way, we are sure that we're testing it properly.
There was a problem hiding this comment.
I agree. I just added a test mocking the clone method to mimic the Safari 18 bug.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Description
Ensures track.enabled state is correctly maintained when cloning MediaStreamTracks. Addresses a Safari 18 bug where cloned tracks are incorrectly enabled during cloning. See https://commits.webkit.org/285916@main for more details.
Bug report
Burndown
Before review
npm test