add support for 3.13t #28

0xDEADFED5 · 2025-02-07T08:54:36Z

add python 3.13t compatibility to twisted-iocpsupport

noticed it was needed after i posted this:
twisted/twisted#12425

for more information, see https://pre-commit.ci

0xDEADFED5 · 2025-02-07T09:14:58Z

GRAALVM_PYTHON is a bit of a hack because the tangle of #ifs in there are pretty good at undefining things needed to build successfully

adiroiban · 2025-02-07T11:41:47Z

setup.py

 from Cython.Build import cythonize

-
+macros = None
+if sysconfig.get_config_var("abi_thread") == "t":


This needs a comment explaining why we need these changes

From what I can read at https://docs.python.org/3/howto/free-threading-extensions.html#building-extensions-for-the-free-threaded-build

as long as we use ciwheelbuilder this is not needed

It will help to have a link to https://docs.python.org/3/howto/free-threading-python.html

and, is this the right way to check for thread free ?

In the Python docs I see

The sysconfig.get_config_var("Py_GIL_DISABLED") configuration variable can be used to determine whether the build supports free threading. If the variable is set to 1, then the build supports free threading. This is the recommended mechanism for decisions related to the build configuration.

adiroiban · 2025-02-07T11:44:17Z

Thanks for the PR... I pushed some changes to enable 3.13 wheels generation on this PR.

I need to read more about the thread free variant of 3.13 ...

We use cibuildwheel and it looks like we need to use CIBW_ENABLE

https://cibuildwheel.pypa.io/en/stable/options/#enable

0xDEADFED5 · 2025-02-07T22:53:16Z

probably more extensive testing needs to be done on the 3.13t binary, but it does work for my use case.

3.13t is going to be an extremely limited pool of users since you have to build Python yourself to even use 3.13t right now. oh wait, i was thinking of JIT. i forgot the installer has a free-threaded option.

adiroiban · 2025-02-10T10:38:44Z

setup.py

-
+macros = None
+if sysconfig.get_config_var("abi_thread") == "t":
+    macros = [("GRAALVM_PYTHON", "1"), ("Py_GIL_DISABLED", "1")]


I was thinking that we don't need this.

Instead, we can just use cibuildwheel and will take care of setting up the build environment.

adiroiban · 2025-02-10T10:52:31Z

Somehow cibuildwheel is not configured ok ... it is still producing wheels for 3.6 and 3.7 ... and there are no wheels for Python 3.13 t

20 wheels produced in 13 minutes:
  twisted_iocpsupport-1.0.4-cp310-cp310-win32.whl              42 kB
  twisted_iocpsupport-1.0.4-cp310-cp310-win_amd64.whl          46 kB
  twisted_iocpsupport-1.0.4-cp311-cp311-win32.whl              42 kB
  twisted_iocpsupport-1.0.4-cp311-cp311-win_amd64.whl          47 kB
  twisted_iocpsupport-1.0.4-cp312-cp312-win32.whl              42 kB
  twisted_iocpsupport-1.0.4-cp312-cp312-win_amd64.whl          47 kB
  twisted_iocpsupport-1.0.4-cp313-cp313-win32.whl              42 kB
  twisted_iocpsupport-1.0.4-cp313-cp313-win_amd64.whl          46 kB
  twisted_iocpsupport-1.0.4-cp36-cp36m-win32.whl               46 kB
  twisted_iocpsupport-1.0.4-cp36-cp36m-win_amd64.whl           54 kB
  twisted_iocpsupport-1.0.4-cp37-cp37m-win32.whl               43 kB
  twisted_iocpsupport-1.0.4-cp37-cp37m-win_amd64.whl           48 kB
  twisted_iocpsupport-1.0.4-cp38-cp38-win32.whl                43 kB
  twisted_iocpsupport-1.0.4-cp38-cp38-win_amd64.whl            47 kB
  twisted_iocpsupport-1.0.4-cp39-cp39-win32.whl                43 kB
  twisted_iocpsupport-1.0.4-cp39-cp39-win_amd64.whl            47 kB
  twisted_iocpsupport-1.0.4-pp310-pypy310_pp73-win_amd64.whl   45 kB
  twisted_iocpsupport-1.0.4-pp37-pypy37_pp73-win_amd64.whl     44 kB
  twisted_iocpsupport-1.0.4-pp38-pypy38_pp73-win_amd64.whl     44 kB
  twisted_iocpsupport-1.0.4-pp39-pypy39_pp73-win_amd64.whl     45 kB

adiroiban · 2025-02-10T11:24:39Z

I think that the build is now ok

  twisted_iocpsupport-1.0.4-cp310-cp310-win32.whl              42 kB
  twisted_iocpsupport-1.0.4-cp310-cp310-win_amd64.whl          46 kB
  twisted_iocpsupport-1.0.4-cp311-cp311-win32.whl              42 kB
  twisted_iocpsupport-1.0.4-cp311-cp311-win_amd64.whl          47 kB
  twisted_iocpsupport-1.0.4-cp312-cp312-win32.whl              42 kB
  twisted_iocpsupport-1.0.4-cp312-cp312-win_amd64.whl          47 kB
  twisted_iocpsupport-1.0.4-cp313-cp313-win32.whl              42 kB
  twisted_iocpsupport-1.0.4-cp313-cp313-win_amd64.whl          46 kB
  twisted_iocpsupport-1.0.4-cp313-cp313t-win32.whl             44 kB
  twisted_iocpsupport-1.0.4-cp313-cp313t-win_amd64.whl         49 kB
  twisted_iocpsupport-1.0.4-cp38-cp38-win32.whl                43 kB
  twisted_iocpsupport-1.0.4-cp38-cp38-win_amd64.whl            47 kB
  twisted_iocpsupport-1.0.4-cp39-cp39-win32.whl                43 kB
  twisted_iocpsupport-1.0.4-cp39-cp39-win_amd64.whl            47 kB
  twisted_iocpsupport-1.0.4-pp310-pypy310_pp73-win_amd64.whl   45 kB
  twisted_iocpsupport-1.0.4-pp37-pypy37_pp73-win_amd64.whl     44 kB
  twisted_iocpsupport-1.0.4-pp38-pypy38_pp73-win_amd64.whl     44 kB
  twisted_iocpsupport-1.0.4-pp39-pypy39_pp73-win_amd64.whl     45 kB

Can you please try the wheel version from https://github.com/twisted/twisted-iocpsupport/actions/runs/13239410326/artifacts/2563932853

this should be the version that we will be publish to PyPi

Thanks

0xDEADFED5 · 2025-02-11T08:56:11Z

just tested twisted_iocpsupport-1.0.4-cp313-cp313t-win_amd64.whl from your artifacts and confirmed it's working with twisted 23.10 and twisted 24.11

adiroiban

Thanks for the changes.

I left a few inline comments.

I am not an expert in Python C extensions... so I just want to make sure that we are ok and future developers will know why we made the current changes.

Can you please check if the changes in setup.py are needed ?

Maybe they are needed to build outside of of cibuildwheel ... but from the docs, it looks like only Py_GIL_DISABLED is needed.

I think that GRAALVM_PYTHON is not related to GIL... and I don't know if it has any effect with our current build process.

Please add some notes about why we need GRAALVM_PYTHON for free threading.

Thanks

adiroiban · 2025-02-11T11:34:47Z

setup.py

 from Cython.Build import cythonize

-
+macros = None
+if sysconfig.get_config_var("abi_thread") == "t":


It will help to have a link to https://docs.python.org/3/howto/free-threading-python.html

and, is this the right way to check for thread free ?

In the Python docs I see

The sysconfig.get_config_var("Py_GIL_DISABLED") configuration variable can be used to determine whether the build supports free threading. If the variable is set to 1, then the build supports free threading. This is the recommended mechanism for decisions related to the build configuration.

0xDEADFED5 · 2025-02-15T09:19:17Z

sorry, i just noticed your comments. yes, i added that code for building locally. i'll add some notes explaining my reasoning tomorrow. basically, it's not easy to set the correct defines because in the iocpsupport.c that gets generated the options get #undef and #define again in many places. GRAALVM_PYTHON just happened to set the right options needed to compile.

edit- and sysconfig.get_config_var("Py_GIL_DISABLED") sounds good!

adiroiban · 2025-02-15T10:57:19Z

GRAALVM_PYTHON just happened to set the right options needed to compile.

Thanks for the info.
I think that it's important to have this comment inside the source file.

As long as the code is documented, I think that we are good to merge this and trigger a new release for twisted-iocpsupport

Thanks again for your help.

for more information, see https://pre-commit.ci

0xDEADFED5 and others added 3 commits February 7, 2025 00:49

add support for 3.13t

8cd2ce5

[pre-commit.ci] auto fixes from pre-commit.com hooks

45761c3

for more information, see https://pre-commit.ci

trim the fat

f4f2501

adiroiban added 2 commits February 7, 2025 11:33

Merge branch 'default' into default

1eca4d0

Enable 3.13... remove 3.6 and 3.7

a829b83

adiroiban reviewed Feb 7, 2025

View reviewed changes

Require Python 3.18 or newer

cf18258

adiroiban closed this Feb 10, 2025

adiroiban reopened this Feb 10, 2025

Use Python 3.13 and latest cibuildwheel for CIBW_ENABLE

88cbca7

adiroiban reviewed Feb 10, 2025

View reviewed changes

Enable free threadindg. Don't build 3.6 and 3.7

fc095de

adiroiban requested changes Feb 11, 2025

View reviewed changes

0xDEADFED5 and others added 3 commits February 16, 2025 00:21

change free-threaded detection to Py_GIL_DISABLED, add macro comments

fe03406

formatting

c13b9e3

[pre-commit.ci] auto fixes from pre-commit.com hooks

17558d8

for more information, see https://pre-commit.ci

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add support for 3.13t #28

add support for 3.13t #28

0xDEADFED5 commented Feb 7, 2025

0xDEADFED5 commented Feb 7, 2025 •

edited

Loading

adiroiban Feb 7, 2025 •

edited

Loading

adiroiban Feb 11, 2025

adiroiban commented Feb 7, 2025

0xDEADFED5 commented Feb 7, 2025 •

edited

Loading

adiroiban Feb 10, 2025

adiroiban commented Feb 10, 2025

adiroiban commented Feb 10, 2025

0xDEADFED5 commented Feb 11, 2025

adiroiban left a comment

adiroiban Feb 11, 2025

0xDEADFED5 commented Feb 15, 2025 •

edited

Loading

adiroiban commented Feb 15, 2025

add support for 3.13t #28

Are you sure you want to change the base?

add support for 3.13t #28

Conversation

0xDEADFED5 commented Feb 7, 2025

0xDEADFED5 commented Feb 7, 2025 • edited Loading

adiroiban Feb 7, 2025 • edited Loading

Choose a reason for hiding this comment

adiroiban Feb 11, 2025

Choose a reason for hiding this comment

adiroiban commented Feb 7, 2025

0xDEADFED5 commented Feb 7, 2025 • edited Loading

adiroiban Feb 10, 2025

Choose a reason for hiding this comment

adiroiban commented Feb 10, 2025

adiroiban commented Feb 10, 2025

0xDEADFED5 commented Feb 11, 2025

adiroiban left a comment

Choose a reason for hiding this comment

adiroiban Feb 11, 2025

Choose a reason for hiding this comment

0xDEADFED5 commented Feb 15, 2025 • edited Loading

adiroiban commented Feb 15, 2025

0xDEADFED5 commented Feb 7, 2025 •

edited

Loading

adiroiban Feb 7, 2025 •

edited

Loading

0xDEADFED5 commented Feb 7, 2025 •

edited

Loading

0xDEADFED5 commented Feb 15, 2025 •

edited

Loading