Go modules #232
Closed
Go modules #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,14 @@ | |||
| module github.com/twitchtv/twirp | |||
There was a problem hiding this comment.
this will not work because Twirp is tagged beyond v1. See #169 for an extended discussion
There was a problem hiding this comment.
Have not tested this, but wouldn't this work with the +incompatible tag in the go.mod?
module example.com/twirp-svc
require github.com/twitchtv/twirp v5.6.0+incompatible
There was a problem hiding this comment.
It will not, because +incompatible indicates that the module does not have a go.mod file...once the repository has a go.mod file then you cannot opt-out of Semantic Import Versioning
|
Will someone take a look at it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#169
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.