Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to go modules and initialize v8 of the project #285

Closed
wants to merge 3 commits into from

Conversation

gurudesu
Copy link

@gurudesu gurudesu commented Nov 4, 2020

This sets up go modules for this repository and changes the base version to v8.

Additionally, this removes the checked in vendor folder of the project.

This resolves #169

Changes to imports

Imports are now updated to github.com/twitchtv/twirp/v8 for users of v8.0.0 and above.

Other than that, no major changes for even users of dep as long as they are using a version of go > LATEST - 3.

Future major revisions will need to go into the ./v9 folder of the repository if there comes a need for another major revision.

Disclaimer

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gurudesu
Copy link
Author

gurudesu commented Nov 5, 2020

Opened this to start a conversation around our go modules approach.

Looks fairly heavy handed in terms of folks providing libraries that wrap twirp. They will have to update their libraries every major version release which is not ideal. Exploring a few things so folks won't need to.

@gurudesu gurudesu marked this pull request as draft November 5, 2020 00:09
@gurudesu gurudesu closed this Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Go Modules
1 participant