Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter for encoding/wkt #198

Merged
merged 1 commit into from
May 2, 2021
Merged

Fix linter for encoding/wkt #198

merged 1 commit into from
May 2, 2021

Conversation

twpayne
Copy link
Owner

@twpayne twpayne commented May 2, 2021

This is a minor follow-up for @andyyang890's excellent #197.

The changes are:

  • Install the goyacc tool.
  • Disable the generation of line numbers in the generated Go code, as these confuse golangci-lint.
  • Replace the generate.sh script with //go:generate lines.
  • Rename the generated file to match the format used elsewhere in the module.
  • Format all files with gofumport.
  • Replace a series of if/else ifs with a switch.

@twpayne twpayne force-pushed the wkt-lint branch 2 times, most recently from eb393f7 to 8e56d71 Compare May 2, 2021 19:15
@twpayne twpayne merged commit 21363ff into master May 2, 2021
@twpayne twpayne deleted the wkt-lint branch May 2, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant