Skip to content

Commit

Permalink
FIX: should not raise error when minimum_required_tags value not defi…
Browse files Browse the repository at this point in the history
…ned for category. (discourse#27658)

While creating a new category if the user didn't specify a value for `minimum_required_tags` input but clicked it then it returned the "PG::NotNullViolation: null value in column 'minimum_required_tags'" error.
  • Loading branch information
vinothkannans authored Jul 1, 2024
1 parent 0b3b101 commit e8a4101
Show file tree
Hide file tree
Showing 3 changed files with 35 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export default class NewCategory extends DiscourseRoute {
search_priority: SEARCH_PRIORITIES.normal,
required_tag_groups: [],
form_template_ids: [],
minimum_required_tags: 0,
});
}

Expand Down
24 changes: 24 additions & 0 deletions spec/system/new_category_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# frozen_string_literal: true

describe "New Category", type: :system do
fab!(:admin)
let(:category_page) { PageObjects::Pages::Category.new }

before { sign_in(admin) }

it "should create category with 0 in minimum_required_tags column when not defined" do
category_page.visit_new_category

category_page.find(".edit-category-tab-general input.category-name").fill_in(
with: "New Category",
)
category_page.find(".edit-category-nav .edit-category-tags a").click
category_page.find(".edit-category-tab-tags #category-minimum-tags").click
category_page.save_settings

expect(page).to have_current_path("/c/new-category/edit/general")

category_page.find(".edit-category-nav .edit-category-tags a").click
expect(category_page.find(".edit-category-tab-tags #category-minimum-tags").value).to eq("0")
end
end
10 changes: 10 additions & 0 deletions spec/system/page_objects/pages/category.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,16 @@ def visit_edit_template(category)
self
end

def visit_categories
page.visit("/categories")
self
end

def visit_new_category
page.visit("/new-category")
self
end

def back_to_category
find(".edit-category-title-bar span", text: "Back to category").click
self
Expand Down

0 comments on commit e8a4101

Please sign in to comment.