Test wait size #177
Merged
Test wait size #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we are seeing test failures:
2025-01-12T15:08:41.8005723Z ______________ TestXcffibTestGenerator.test_XcffibTest_generator _______________
2025-01-12T15:08:41.8006225Z [gw2] linux -- Python 3.12.8 /home/runner/work/xcffib/xcffib/xcffib-test-abi.Qm0sy2VpHW/bin/python
2025-01-12T15:08:41.8006537Z
2025-01-12T15:08:41.8006732Z self = <test.test_python_code.TestXcffibTestGenerator object at 0x7f02c3f4cfb0>
2025-01-12T15:08:41.8006989Z
2025-01-12T15:08:41.8007090Z def test_XcffibTest_generator(self):
2025-01-12T15:08:41.8007303Z try:
2025-01-12T15:08:41.8007486Z old_display = os.environ['DISPLAY']
2025-01-12T15:08:41.8007715Z except KeyError:
2025-01-12T15:08:41.8007898Z old_display = ""
2025-01-12T15:08:41.8008110Z # use some non-default width/height
2025-01-12T15:08:41.8008374Z with XcffibTest(width=1001, height=502) as test:
2025-01-12T15:08:41.8008648Z assert os.environ['DISPLAY'] != old_display
2025-01-12T15:08:41.8009065Z setup = test.conn.get_setup()
2025-01-12T15:08:41.8009300Z screen = setup.roots[0]
2025-01-12T15:08:41.8009522Z width = screen.width_in_pixels
2025-01-12T15:08:41.8009758Z height = screen.height_in_pixels
2025-01-12T15:08:41.8009988Z > assert width == 1001
2025-01-12T15:08:41.8010183Z E assert 800 == 1001
2025-01-12T15:08:41.8010307Z
2025-01-12T15:08:41.8010408Z test/test_python_code.py:219: AssertionError
https://github.com/tych0/xcffib/actions/runs/12734629978/job/35492430285
which is because of the way xvfb bootstraps screens. this race has been
around "forever", but we are probably only starting to see it now because
we are doing a lot more in parallel, and thus maxing out github runners'
cpus and widening race windows.
Signed-off-by: Tycho Andersen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.