module: guard against null return from xcb_get_extension_data() #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see comment for details... this probably doesn't *really* occur in the wild very much, but we uncovered it in our parallel testing, and didn't quite get it fixed in d3c25ee ("module: be less strange about extension key lifetimes") (although that was probably also a bug and a nice cleanup anyway at net negative lines, this is likely the real source of the seg fault). Signed-off-by: Tycho Andersen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see comment for details... this probably doesn't really occur in the wild very much, but we uncovered it in our parallel testing, and didn't quite get it fixed in d3c25ee ("module: be less strange about extension key lifetimes") (although that was probably also a bug and a nice cleanup anyway at net negative lines, this is likely the real source of the seg fault).