-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate boilerplate in shared sources #4302
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change – seems more convenient to work with.
I wonder if it is possible to change a location of boilerplate source files too. |
Yes, this is possible. Here's how sbt-tl uses its own sources in its build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I took another look at this, and I'm not that crazy about it. I don't like changing default settings for a particular build. IMO either
- this seems like an IntelliJ issue that should be fixed instead of worked-around.
- it's an sbt issue and it should be changed at a higher-level (e.g. sbt-typelevel or sbt itself ideally)
I suspect it's more of a (1) :)
I agree it should be fixed in Intellij but I don't see why it means that it shouldn't be worked around.
Dunno, I think most projects don't generate boilerplate. This change only makes sense when the generated boilerplate is shared sources in a cross-compiled module. And needs a |
c7ff1de
to
bb2aaf8
Compare
to a place that works for Intellij
bb2aaf8
to
fe902de
Compare
to a place that works for Intellij