Currency instances #4564
Currency instances #4564
Conversation
kernel/src/main/scala/cats/kernel/instances/CurrencyInstances.scala
Outdated
Show resolved
Hide resolved
| implicit private val arbitraryCurrency: Arbitrary[Currency] = Arbitrary( | ||
| Gen.oneOf(Currency.getAvailableCurrencies().asScala) | ||
| ) | ||
| implicit private val cogenCurrency: Cogen[Currency] = Cogen[String].contramap(_.getCurrencyCode()) |
There was a problem hiding this comment.
Perhaps, it would not hurt if we put these instances into cats.laws.discipline.arbitrary to make them available for everyone.
There was a problem hiding this comment.
I'm wrapping my head around the dependency graph here. Doesn't the laws module depend on this one? If we want to add these instances to kernel-laws, is there a way to add jvm-only code without moving too many files (kernel-laws is defined as CrossType.Pure)? Sorry not very used to cross compilation.
There was a problem hiding this comment.
Yeah, it is quite confusing. If it is not possible to do it in a simple way, let's keep it private in the tests for now then.
| @@ -48,4 +49,8 @@ private[cats] object scalaVersionSpecific { | |||
| that: T | |||
| )(implicit w1: A => TraversableLike[El1, Repr1], w2: T => IterableLike[El2, Repr2]) = (a, that).zipped | |||
| } | |||
|
|
|||
| implicit class setExtension[A](private val a: A) extends AnyVal { | |||
| def asScala(s: java.util.Set[A]): mutable.Set[A] = `set asScala`(s) | |||
There was a problem hiding this comment.
@armanbilge any better idea?
|
Is the |
|
Hi @massimosiani , sorry for the long reply. Looks like your PR got buried under a pile of others, although it looks pretty mature. Would you be interested to move it forward? In such a case, would you update it to the current |
Addresses #4562.
I followed the steps outlined here #3910 (comment), there's no
Currencyin scala js/native tough.