Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update munit to 1.0.3 #4684

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Update munit to 1.0.3 #4684

merged 1 commit into from
Dec 24, 2024

Conversation

typelevel-steward[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates org.scalameta:munit from 1.0.2 to 1.0.3

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

πŸ” Files still referring to the old version number

The following files still refer to the old version number (1.0.2).
You might want to review and update them manually.

CHANGES.md
βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scalameta", artifactId = "munit" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta", artifactId = "munit" }
}]
labels: test-library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

@satorg
Copy link
Contributor

satorg commented Dec 3, 2024

Surprisingly, this PR is failing not because of scala-native but rather scala-js: it looks like the new MUnit requires scala-js v1.17, but Cats is stuck on v1.16. Also it looks like the update to v1.17 has never been proposed by typelevel-steward.

I wonder – does it make sense to include the update to scala-js v1.17 into this PR to unblock it, or are there known issues with that scala-js release?

@mzuehlke
Copy link
Contributor

mzuehlke commented Dec 3, 2024

scala-js is fixed to 1.16 for the typelevel Steward: https://github.com/typelevel/steward/blob/main/.github/.scala-steward.conf

@mzuehlke
Copy link
Contributor

mzuehlke commented Dec 3, 2024

To add, in the past @armanbilge enabled Scala-JS updates πŸ””

@mzuehlke
Copy link
Contributor

mzuehlke commented Dec 3, 2024

@mzuehlke
Copy link
Contributor

This PR needs to be rebased. Steward will only update it in case of a conflict. And there is none,

Alternatively a fresh PR would work, too.

@satorg satorg force-pushed the update/munit-1.0.3 branch from 5d7db18 to 86526b4 Compare December 24, 2024 19:37
@satorg satorg merged commit afb75fc into main Dec 24, 2024
17 checks passed
@satorg satorg deleted the update/munit-1.0.3 branch December 24, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants