site: add Tracing - interop with Java-instrumented libraries page
#353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRevive
force-pushed
the
docs/java-interop
branch
2 times, most recently
from
dd88b4e to
8cb5194
Compare
iRevive
force-pushed
the
docs/java-interop
branch
from
8cb5194 to
c40c69f
Compare
armanbilge
reviewed
Nov 4, 2023
NthPortal
reviewed
Nov 8, 2023
| def run: IO[Unit] = | ||
| IOLocal(Context.root).flatMap { implicit ioLocal: IOLocal[Context] => | ||
| implicit val local: Local[IO, Context] = localForIoLocal | ||
| val otelJava: OtelJava[IO] = OtelJava.local(GlobalOpenTelemetry.get()) |
There was a problem hiding this comment.
IIRC, otel recommends not using the global instance. is there another instance we can use relatively easily in examples? because examples invariably get copied into non-example code and end up in production
There was a problem hiding this comment.
An instance can be created AutoConfiguredOpenTelemetrySdk.builder().build(). It creates an autoconfigured instance and does not make it global.
But in this particular example, it must be global because the instance is created by the Otel javaagent upon JVM startup.
There was a problem hiding this comment.
IIRC, otel recommends not using the global instance.
But other examples could be updated (e.g. #348)
iRevive
force-pushed
the
docs/java-interop
branch
from
09087e7 to
eb16ba7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #202.