Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test pull requests to show Gabriel how the whole PR process is done #163

Closed
wants to merge 4 commits into from
Closed

Test pull requests to show Gabriel how the whole PR process is done #163

wants to merge 4 commits into from

Conversation

TonioGela
Copy link
Member

@TonioGela TonioGela commented Mar 29, 2024 •
edited
Loading

Ignore this pull request that I will promptly close.

@mergify mergify bot added the tests label Mar 29, 2024
TonioGela
TonioGela commented Mar 29, 2024
View reviewed changes
Copy link
Member Author

@TonioGela TonioGela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there are a couple of changes to do

tests/shared/src/test/scala/org/typelevel/toolkit/HelloWorldSpec.scala Show resolved Hide resolved
@TonioGela TonioGela requested review from armanbilge and removed request for armanbilge March 29, 2024 21:36
@TonioGela TonioGela closed this Mar 29, 2024
@TonioGela TonioGela reopened this Mar 29, 2024
@TonioGela TonioGela closed this Mar 29, 2024
@TonioGela TonioGela deleted the fix-documentation branch March 29, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TonioGela