feat: examples for flat configs and type information #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bradzacher
reviewed
Feb 10, 2024
| npm run lint | ||
| ``` | ||
|
|
||
| ```plaintext |
There was a problem hiding this comment.
Should this be a snapshot or tested or something to validate it does what we expect?
|
|
||
| ## Setup | ||
|
|
||
| ```shell |
There was a problem hiding this comment.
Should probably use npm2yarn here?
| import eslint from "@eslint/js"; | ||
| import tseslint from "typescript-eslint"; | ||
|
|
||
| export async function unecessarilyAsync() { |
There was a problem hiding this comment.
Should we be mixing config and test case?
There was a problem hiding this comment.
Heh, it was the shortest path to getting a .js file linted.
| @@ -3,7 +3,7 @@ | |||
| "version": "0.0.0", | |||
| "description": "Various examples of working with typescript-eslint. 📝", | |||
| "main": "index.js", | |||
| "repository": "https://github.com/typescript-eslint/typescript-eslint-examples", | |||
| "repository": "typescript-eslint/typescript-eslint-examples", | |||
There was a problem hiding this comment.
Heh I only recently learned this was a thing. JoshuaKGoldberg/eslint-plugin-package-json#71
This was referenced Feb 12, 2024
bradzacher
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3.
Also cleans up the
repositoryfield inpackage.jsonfiles.Note that until v7 is released in two days, the
typescript-eslintpackage needs to be symlinked locally.