attic action support, spacing fix with project count, and other small changes #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue with running ./scripts/watch
|
So I actually added the |
|
i've been trying to test out whether or not attic works and I'm not exactly getting/finding a good way of feedback for the eval failures. |
Fixes {number here}project and depending on the number it will show "No
projects", 1 project, or *x* projects
itslychee
force-pushed
the
itslychee/random-fixes-and-additions
branch
from
fbe2b0a to
46a509e
Compare
|
I no longer use typhon but if anyone wants to take this PR feel free to! |
|
(also closing this because there seems to be a rewrite so not particularly concerned about this) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
really don't know of a better PR title for this, but each commit here is self-documented and reviews are welcomed. The most notable one would be adding the attic action but I also have a few "fixes" regarding a bug I encountered with the project display count looking like
0projects.This addresses:
I have tested the script via
cat secrets.json | /nix/store/..../bin/actionand all does seem to work, but I'll test this again in a more realistic environment with repositories.