Moved UnusedConstructor suppress to psalm.xml.dist

typhoon-php · Feb 22, 2024 · a79d065 · a79d065
1 parent 8957df5
commit a79d065
Show file tree

Hide file tree

Showing 11 changed files with 37 additions and 21 deletions.
diff --git a/psalm.xml.dist b/psalm.xml.dist
@@ -46,6 +46,7 @@
     </ignoreExceptions>
 
     <issueHandlers>
+        <UnusedConstructor errorLevel="suppress"/>
         <MissingThrowsDocblock>
             <errorLevel type="suppress">
                 <directory name="tests"/>

diff --git a/src/PhpParserReflector/ClassReflections.php b/src/PhpParserReflector/ClassReflections.php
@@ -9,11 +9,12 @@
 use PhpParser\Node\Stmt\Enum_;
 use Typhoon\Reflection\ClassReflection;
 
+/**
+ * @internal
+ * @psalm-internal Typhoon\Reflection\PhpParserReflector
+ */
 final class ClassReflections
 {
-    /**
-     * @psalm-suppress UnusedConstructor
-     */
     private function __construct() {}
 
     /**

diff --git a/src/PhpParserReflector/EnumReflections.php b/src/PhpParserReflector/EnumReflections.php
@@ -10,11 +10,12 @@
 use Typhoon\Reflection\Metadata\TypeMetadata;
 use Typhoon\Type\types;
 
+/**
+ * @internal
+ * @psalm-internal Typhoon\Reflection\PhpParserReflector
+ */
 final class EnumReflections
 {
-    /**
-     * @psalm-suppress UnusedConstructor
-     */
     private function __construct() {}
 
     /**

diff --git a/src/PhpParserReflector/FixNodeStartLineVisitor.php b/src/PhpParserReflector/FixNodeStartLineVisitor.php
@@ -7,6 +7,10 @@
 use PhpParser\Node;
 use PhpParser\NodeVisitorAbstract;
 
+/**
+ * @internal
+ * @psalm-internal Typhoon\Reflection\PhpParserReflector
+ */
 final class FixNodeStartLineVisitor extends NodeVisitorAbstract
 {
     private const START_LINE_ATTRIBUTE = 'startLine';

diff --git a/src/PhpParserReflector/MethodReflections.php b/src/PhpParserReflector/MethodReflections.php
@@ -10,11 +10,12 @@
 use PhpParser\NodeTraverser;
 use PhpParser\NodeVisitorAbstract;
 
+/**
+ * @internal
+ * @psalm-internal Typhoon\Reflection\PhpParserReflector
+ */
 final class MethodReflections
 {
-    /**
-     * @psalm-suppress UnusedConstructor
-     */
     private function __construct() {}
 
     public static function isGenerator(ClassMethod $node): bool

diff --git a/src/PhpParserReflector/NativeTypeReflections.php b/src/PhpParserReflector/NativeTypeReflections.php
@@ -11,11 +11,12 @@
 use Typhoon\Type\Type;
 use Typhoon\Type\types;
 
+/**
+ * @internal
+ * @psalm-internal Typhoon\Reflection\PhpParserReflector
+ */
 final class NativeTypeReflections
 {
-    /**
-     * @psalm-suppress UnusedConstructor
-     */
     private function __construct() {}
 
     public static function reflect(TypeContext $typeContext, Node $node, bool $implicitlyNullable = false): Type

diff --git a/src/PhpParserReflector/ParameterReflections.php b/src/PhpParserReflector/ParameterReflections.php
@@ -8,11 +8,12 @@
 use PhpParser\Node\Param;
 use PhpParser\Node\Stmt\Class_;
 
+/**
+ * @internal
+ * @psalm-internal Typhoon\Reflection\PhpParserReflector
+ */
 final class ParameterReflections
 {
-    /**
-     * @psalm-suppress UnusedConstructor
-     */
     private function __construct() {}
 
     public static function isPromoted(Param $node): bool

diff --git a/src/PhpParserReflector/PropertyReflections.php b/src/PhpParserReflector/PropertyReflections.php
@@ -8,11 +8,12 @@
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\Property;
 
+/**
+ * @internal
+ * @psalm-internal Typhoon\Reflection\PhpParserReflector
+ */
 final class PropertyReflections
 {
-    /**
-     * @psalm-suppress UnusedConstructor
-     */
     private function __construct() {}
 
     /**

diff --git a/src/TypeContext/RuntimeExistenceChecker.php b/src/TypeContext/RuntimeExistenceChecker.php
@@ -4,6 +4,10 @@
 
 namespace Typhoon\Reflection\TypeContext;
 
+/**
+ * @internal
+ * @psalm-internal Typhoon\Reflection\TypeContext
+ */
 final class RuntimeExistenceChecker implements ConstantExistenceChecker, ClassExistenceChecker
 {
     public function constantExists(string $name): bool

diff --git a/src/TypeContext/TypeContext.php b/src/TypeContext/TypeContext.php
@@ -11,6 +11,10 @@
 use Typhoon\Type\Type;
 use Typhoon\Type\types;
 
+/**
+ * @internal
+ * @psalm-internal Typhoon\Reflection
+ */
 final class TypeContext implements NameResolver
 {
     /**

diff --git a/tests/unit/FixturesProvider.php b/tests/unit/FixturesProvider.php
@@ -11,9 +11,6 @@ final class FixturesProvider
      */
     private static ?array $classes = null;
 
-    /**
-     * @psalm-suppress UnusedConstructor
-     */
     private function __construct() {}
 
     /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -11,9 +11,6 @@ final class FixturesProvider @@
          */
         private static ?array $classes = null;
-        /**
-         * @psalm-suppress UnusedConstructor
-         */
         private function __construct() {}
         /**
@@ Expand Down @@