Removed ValueType (#22)

typhoon-php · Mar 9, 2024 · da04785 · da04785
1 parent e2ec2dd
commit da04785
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 27 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,3 +8,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## 0.3.1
 
 - Deprecated calling `types::alias()`, `types::template()` and `types::object()` with named arguments.
+- Deprecated `TypeVisitor::value()` and `DefaultVisitor::value()`.
diff --git a/DefaultTypeVisitor.php b/DefaultTypeVisitor.php
@@ -181,6 +181,9 @@ public function union(Type $self, array $types): mixed
         return $this->default($self);
     }
 
+    /**
+     * @deprecated will be removed in 0.4.0
+     */
     public function value(Type $self, Type $type): mixed
     {
         return $this->default($self);

diff --git a/Internal/ValueType.php b/Internal/ValueType.php
diff --git a/TypeVisitor.php b/TypeVisitor.php
@@ -219,6 +219,7 @@ public function truthyString(Type $self): mixed;
     public function union(Type $self, array $types): mixed;
 
     /**
+     * @deprecated will be removed in 0.4.0
      * @return TReturn
      */
     public function value(Type $self, Type $type): mixed;

diff --git a/types.php b/types.php
@@ -427,7 +427,7 @@ public static function union(Type ...$types): Type
 
     public static function value(Type $type): Type
     {
-        return new Internal\ValueType($type);
+        return self::offset($type, self::key($type));
     }
 
     /**
Original file line number	Diff line number	Diff line change
Expand Up		@@ -8,3 +8,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
		## 0.3.1

		- Deprecated calling `types::alias()`, `types::template()` and `types::object()` with named arguments.
		- Deprecated `TypeVisitor::value()` and `DefaultVisitor::value()`.
-Original file line number
+Diff line change
@@ Expand Up / @@ -427,7 +427,7 @@ public static function union(Type ...$types): Type @@
         public static function value(Type $type): Type
         {
-            return new Internal\ValueType($type);
+            return self::offset($type, self::key($type));
         }
         /**
@@ Expand Down @@