Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effective Collection implementation with arbitrary keys #86

Closed
wants to merge 8 commits into from

Conversation

vudaltsov
Copy link
Member

No description provided.

@vudaltsov vudaltsov requested a review from a team August 25, 2024 02:22
@vudaltsov vudaltsov self-assigned this Aug 25, 2024
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 167 lines in your changes missing coverage. Please review.

Project coverage is 39.92%. Comparing base (fd9bc92) to head (da90fe6).

Files Patch % Lines
src/Collection/Collection.php 0.00% 89 Missing ⚠️
src/Collection/KeyHasher.php 0.00% 53 Missing ⚠️
src/Collection/ValueStringifier.php 0.00% 23 Missing ⚠️
src/Collection/KeyIsNotDefined.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              0.4.x      #86      +/-   ##
============================================
- Coverage     40.99%   39.92%   -1.07%     
- Complexity     2268     2340      +72     
============================================
  Files           217      221       +4     
  Lines          6247     6414     +167     
============================================
  Hits           2561     2561              
- Misses         3686     3853     +167     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vudaltsov vudaltsov closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant