Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jq all json first draft #192

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Jq all json first draft #192

merged 2 commits into from
Jan 6, 2025

Conversation

SeriousHorncat
Copy link
Collaborator

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines enforced by static analysis tools.
  • If it is a core feature, I have added thorough tests.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Will this be part of a product update? If yes, please write one phrase about this update.

Pull Request Details

Wrike Ticket - JQ to validate and format all JSON consistently for Rosalution

Changes made:

  • Formatted JSON within Rosalution using JQ
  • Updated README for Optional Jq installation
  • Updated PR template to have folks check if the new/updated JSON is formatted with Jq

To Review:

  • Static Analysis by Reviewer
  • All Github Actions checks have passed.

@SeriousHorncat SeriousHorncat self-assigned this Jan 6, 2025
@SeriousHorncat SeriousHorncat marked this pull request as ready for review January 6, 2025 23:09
@JmScherer
Copy link
Collaborator

Ran pytest to ensure the json still works for the test fixtures:

Screenshot 2025-01-06 at 5 16 58 PM

I did not see any frontend json fixtures to test, it looks good.

Copy link
Collaborator

@JmScherer JmScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The json looks great! Approved

@SeriousHorncat SeriousHorncat merged commit 8802e4d into main Jan 6, 2025
8 checks passed
@SeriousHorncat SeriousHorncat deleted the jq-all-json-first-draft branch January 6, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants