Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace request-promise with node-fetch #68

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Replace request-promise with node-fetch #68

merged 4 commits into from
Oct 30, 2024

Conversation

justin0022
Copy link
Member

resolves #67.

This package will only support esm and no longer cjs, as the newest version of node-fetch no longer supports cjs. Cjs is becoming less common anyway. This is a breaking change.

src/downloadFile.js Fixed Show fixed Hide fixed
src/downloadFile.js Fixed Show fixed Hide fixed
src/downloadFile.js Fixed Show fixed Hide fixed
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@justin0022 justin0022 marked this pull request as ready for review October 30, 2024 22:36
@justin0022 justin0022 merged commit 73a68d9 into master Oct 30, 2024
2 checks passed
@justin0022 justin0022 mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove request-promise package
1 participant