Always install npm dependencies during build

Some node dependencies, such as `node-sass`, are platform-specific - mounting `node_modules` leads to the Docker build using missing the correct platform dependencies. See webpack-contrib/sass-loader#563 (comment)
ubclaunchpad · May 21, 2018 · 8c11f68 · 8c11f68
1 parent b048567
commit 8c11f68
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/.dockerignore b/.dockerignore
@@ -23,3 +23,4 @@ client
 
 # Dependencies
 bin
+daemon/web/node_modules
diff --git a/Dockerfile b/Dockerfile
@@ -7,9 +7,7 @@ ENV BUILD_HOME=/go/src/github.com/ubclaunchpad/inertia/daemon/web
 ADD ./daemon/web ${BUILD_HOME}
 WORKDIR ${BUILD_HOME}
 # Build and minify client.
-RUN if [ ! -d "node_modules" ]; then \
-    npm install --production; \
-    fi
+RUN npm install --production
 RUN npm run build
 
 ### Part 2 - Building the Inertia daemon
Original file line number	Diff line number	Diff line change
Expand Up		@@ -23,3 +23,4 @@ client

		# Dependencies
		bin
		daemon/web/node_modules