Skip to content

Commit

Permalink
Merge pull request #541 from ubclaunchpad/clean-up-templates
Browse files Browse the repository at this point in the history
chore: clean up issue and pull request templates
  • Loading branch information
Cheuk Yin Ng authored Oct 6, 2020
2 parents 4394c76 + 6dfb2f5 commit 2f1d654
Show file tree
Hide file tree
Showing 5 changed files with 71 additions and 33 deletions.
23 changes: 17 additions & 6 deletions .github/ISSUE_TEMPLATE/bug-report.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,32 @@ assignees: ''

---

**Describe the bug**
## Summary

<!--
A clear and concise description of what the bug is.
-->

## Reproduction steps

**To Reproduce**
<!--
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
5. -->

**Expected behavior**
A clear and concise description of what you expected to happen.
## Expected behaviour

**Screenshots**
<!--
A clear and concise description of what you expected to happen.
If applicable, add screenshots to help explain your problem.
-->

## Context

**Additional context**
<!--
Add any other context about the problem here.
-->
14 changes: 11 additions & 3 deletions .github/ISSUE_TEMPLATE/feature-request.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,23 @@ assignees: ''

---

**Please give a one-sentence summary of the feature you would like to see.**
## Summary

<!--
E.g. "we should be able to give nicknames to other Rocket 2 users."
-->

**Please give as many details as possible about the requirements for the feature.**
## Requirements

<!--
E.g. "every user should be able to have an arbitrary number of nicknames, and users should be able to give each other nicknames."
**Please list any additional context.**
Implementation details could also go here.
-->

## Context

<!--
For instance, if this was requested by a Launch Pad president, if it has been discussed somewhere else like Slack, etc.
E.g. "nicknames are required for the new website."
-->
28 changes: 28 additions & 0 deletions .github/ISSUE_TEMPLATE/refactor.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
---
name: Refactoring & Cleanup
about: Request refactoring or code cleanup
title: ''
labels: refactoring & cleanup
assignees: ''

---

## Summary

<!--
Please give a one-sentence summary of the cleanup you would like done.
-->

## Requirements

<!--
Please give as many details as possible about the cleanup or refactoring.
List what areas of the code base this would affect and possible implementation
details.
-->

## Context

<!--
Any additional context behind the reason for this change.
-->
14 changes: 0 additions & 14 deletions .github/ISSUE_TEMPLATE/refactoring---cleanup.md

This file was deleted.

25 changes: 15 additions & 10 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,21 @@
# Pull Request
<!-- Give a brief description of your changes here. -->

## Description

**Give a brief description of your changes:**
## Ticket(s)

## Testing
<!--
e.g. "Affects #123"
**If testing this change requires extra setup, please document it here:**
Create a copy of that line for each Github Issue affected, and replace
"Affects" with "Closes" if merging this will close the relevant ticket. If this
change is not for a particular ticket, just write "n/a" instead.
-->

## Ticket(s)
## Details

Affects #
<!--
Provide a more detailed rundown of your change - examples commands and results,
screenshots, etc. Also provide special testing instructions if there are any.
(Create a copy of that line for each Github Issue affected,
and replace "Affects" with "Closes" if merging this will close the relevant ticket.)
Also provide additional context on the change, if the affected issues are not
very detailed.
-->

0 comments on commit 2f1d654

Please sign in to comment.