Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 200 codes from ResponseTuples in function signatures #543

Open
chuck-sys opened this issue Oct 6, 2020 · 0 comments
Open

Remove 200 codes from ResponseTuples in function signatures #543

chuck-sys opened this issue Oct 6, 2020 · 0 comments
Labels
good first issue Good for newcomers theme:refactoring Something needs to be cleaned up or refactored

Comments

@chuck-sys
Copy link
Collaborator

Summary

Remove 200 codes from ResponseTuples in function signatures

Requirements

All commands, whether they do something well or not (unless in the case of internal server failure, in which case a status code of 5xx is auto-returned), must return 200, no matter what. If that's the case, we should return 200 for all of them and just pull it up into the handle function.
@chuck-sys chuck-sys added good first issue Good for newcomers theme:refactoring Something needs to be cleaned up or refactored labels Oct 6, 2020
@chuck-sys chuck-sys mentioned this issue Oct 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers theme:refactoring Something needs to be cleaned up or refactored
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chuck-sys