tests: increase clarity by a marginal amount, **rm api and tests/api** #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #583 +/- ##
==========================================
- Coverage 93.54% 93.01% -0.54%
==========================================
Files 47 42 -5
Lines 2712 2420 -292
Branches 370 323 -47
==========================================
- Hits 2537 2251 -286
+ Misses 115 110 -5
+ Partials 60 59 -1
Continue to review full report at Codecov.
|
Slack commands by default should always give 200 codes, meaning that any other code is pointless. It represents that the message was well received by the other party. Replacing it with an underscore retains clarity.
chuck-sys
changed the title
chuck-sys
changed the title
bobheadxi
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s)
Closes #531
Details
Since I am reasonably satisfied with the size of the tests (for some reason even after I made the PR from last time this still stays), I will close this. Should have closed this like 23 days ago.
--inspectself.assertEqual(code, 200)because there is no other possible code that you can actually output (so no testing)self.assertTupleEqual()functions weren't touched because removing the status code would make it more difficult to read200codes from ResponseTuples in function signatures #543apiandtests/apito alleviate confusion on inconsistency between command logics