-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export emails #591
feat: export emails #591
Conversation
Codecov Report
@@ Coverage Diff @@
## master #591 +/- ##
==========================================
- Coverage 93.09% 92.67% -0.43%
==========================================
Files 42 43 +1
Lines 2420 2524 +104
Branches 323 337 +14
==========================================
+ Hits 2253 2339 +86
- Misses 109 123 +14
- Partials 58 62 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just got off a meeting (that I couldn't do a code review in, boohoo). But now that I'm out....
(Great job btw)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things.
This reverts commit 1b64210.
Co-authored-by: Cheuk Yin Ng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. May need some tests for handle_char_limit_exceeded()
. Other than that only some minor things in docs.
Ticket(s)
Closes #539
Details
/rocket export emails
for exporting emails of all users + list of all the users who don't have an emailExample run of the command: